Use default console subsystem on Windows for dev builds

servo · Sep 28, 2016 · da8f06b · da8f06b
1 parent a082501
commit da8f06b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py
@@ -259,9 +259,11 @@ def build(self, target=None, release=False, dev=False, jobs=None,
                             servo_exe_dir)
                 if "msvc" in (target or host_triple()):
                     msvc_x64 = "64" if "x86_64" in (target or host_triple()) else ""
-                    # on msvc builds, use editbin to change the subsystem to windows
-                    call(["editbin", "/nologo", "/subsystem:windows", path.join(servo_exe_dir, "servo.exe")],
-                         verbose=verbose)
+                    # on msvc builds, use editbin to change the subsystem to windows, but only
+                    # on release builds -- on debug builds, it hides log output
+                    if not dev:
+                        call(["editbin", "/nologo", "/subsystem:windows", path.join(servo_exe_dir, "servo.exe")],
+                             verbose=verbose)
                     # on msvc, we need to copy in some DLLs in to the servo.exe dir
                     for ssl_lib in ["ssleay32md.dll", "libeay32md.dll"]:
                         shutil.copy(path.join(env['OPENSSL_LIB_DIR'], "../bin" + msvc_x64, ssl_lib),