Implement [LenientThis] support and enable it in Document.webidl

Closes issue #3760
servo · Oct 25, 2014 · e023662 · e023662
1 parent 0c12f63
commit e023662
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py
@@ -2526,9 +2526,9 @@ def __init__(self, descriptor, lenientThis=False):
         if lenientThis:
             name = "genericLenientGetter"
             unwrapFailureCode = (
-                "MOZ_ASSERT(!JS_IsExceptionPending(cx));\n"
-                "JS_SET_RVAL(cx, vp, JS::UndefinedValue());\n"
-                "return true;")
+                "assert!(JS_IsExceptionPending(cx) == 0);\n"
+                "*vp = UndefinedValue();\n"
+                "return 1;")
         else:
             name = "genericGetter"
             unwrapFailureCode = None
@@ -2600,8 +2600,8 @@ def __init__(self, descriptor, lenientThis=False):
         if lenientThis:
             name = "genericLenientSetter"
             unwrapFailureCode = (
-                "MOZ_ASSERT(!JS_IsExceptionPending(cx));\n"
-                "return true;")
+                "assert!(JS_IsExceptionPending(cx) == 0);\n"
+                "return 1;")
         else:
             name = "genericSetter"
             unwrapFailureCode = None
@@ -4136,11 +4136,11 @@ def __init__(self, descriptor):
         if hasGetter:
             cgThings.append(CGGenericGetter(descriptor))
         if hasLenientGetter:
-            pass
+            cgThings.append(CGGenericGetter(descriptor, lenientThis=True))
         if hasSetter:
             cgThings.append(CGGenericSetter(descriptor))
         if hasLenientSetter:
-            pass
+            cgThings.append(CGGenericSetter(descriptor, lenientThis=True))
 
         if descriptor.concrete:
             cgThings.append(CGClassFinalizeHook(descriptor))

diff --git a/components/script/dom/webidls/Document.webidl b/components/script/dom/webidls/Document.webidl
@@ -79,6 +79,6 @@ partial interface Document {
   NodeList getElementsByName(DOMString elementName);
 
   // special event handler IDL attributes that only apply to Document objects
-  /*[LenientThis]*/ attribute EventHandler onreadystatechange;
+  [LenientThis] attribute EventHandler onreadystatechange;
 };
 Document implements GlobalEventHandlers;