Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove interior borders during flow construction
Instead of looking at the boundaries of the text run, set the border width to zero and the border style to none on border sides that are not the outermost for a node container that is display: inline.
- Loading branch information
Showing
6 changed files
with
74 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<html> | ||
<head> | ||
<style> | ||
code { | ||
border: 2px solid #ccc; | ||
} | ||
</style> | ||
</head> | ||
<body> | ||
<code>Quotes: "".</code> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<html> | ||
<head> | ||
<style> | ||
code { | ||
border: 2px solid #ccc; | ||
} | ||
</style> | ||
</head> | ||
<body> | ||
<code>Quotes: "".</code> | ||
</body> | ||
</html> |
ec2fa25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at bjwbell@ec2fa25
ec2fa25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging bjwbell/servo/borders-txt-nodes = ec2fa25 into auto
ec2fa25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bjwbell/servo/borders-txt-nodes = ec2fa25 merged ok, testing candidate = b2f0990
ec2fa25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://build.servo.org/builders/linux1/builds/874
success: http://build.servo.org/builders/linux2/builds/872
success: http://build.servo.org/builders/android/builds/908
success: http://build.servo.org/builders/mac1/builds/1089
success: http://build.servo.org/builders/mac2/builds/1089
success: http://build.servo.org/builders/gonk/builds/60
ec2fa25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = b2f0990