Let the popstate and hashchange events not bubble

servo · Jun 17, 2018 · ecb6547 · ecb6547
1 parent 0c5b020
commit ecb6547
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/components/script/dom/history.rs b/components/script/dom/history.rs
@@ -129,7 +129,7 @@ impl History {
             let event = HashChangeEvent::new(
                 &self.window,
                 atom!("hashchange"),
-                true,
+                false,
                 false,
                 old_url.into_string(),
                 url.into_string());

diff --git a/components/script/dom/popstateevent.rs b/components/script/dom/popstateevent.rs
@@ -71,7 +71,7 @@ impl PopStateEvent {
     pub fn dispatch_jsval(target: &EventTarget,
                           window: &Window,
                           state: HandleValue) {
-        let event = PopStateEvent::new(window, atom!("popstate"), true, false, state);
+        let event = PopStateEvent::new(window, atom!("popstate"), false, false, state);
         event.upcast::<Event>().fire(target);
     }
 }

diff --git a/tests/wpt/metadata/html/browsers/browsing-the-web/history-traversal/popstate_event.html.ini b/tests/wpt/metadata/html/browsers/browsing-the-web/history-traversal/popstate_event.html.ini