Skip to content
This repository has been archived by the owner on Jan 30, 2019. It is now read-only.

Fix for parsing LSF Transition state parameters #194

Merged
merged 5 commits into from Jan 13, 2016

Conversation

dotMorten
Copy link
Contributor

  • Makes State parameters optional by making them nullable
  • Uses the key names rather than the parameter order to parse the provided state (order isn't specific nor are all parameters necessarily there)

@zhuridartem

Parameters aren't required in a transition, so make them nullable.
The code was expecting parameters in a certain order, but not all parameters are required, and order isn't specified. Instead use string comparison and look for the possible keys.
@msftclas
Copy link

Hi @dotMorten, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@zhuridartem
Copy link
Contributor

Looks good.

@dotMorten
Copy link
Contributor Author

@zhuridartem Was just thinking... I'm not sure if line 713 needs a similar fix? Couldn't really make sense of it.

@dotMorten
Copy link
Contributor Author

@zhuridartem Strike that. The edit in the second file was apparently already fixed in your dev branch and I wasn't paying attention when merging my fix over* :). So only thing left is the nullable stuff.

*Btw this also means you should update the DSB project template in the visual studio gallery, since the dictionary key check is a quite important fix.

bfjelds added a commit that referenced this pull request Jan 13, 2016
Fix for parsing LSF Transition state parameters
@bfjelds bfjelds merged commit 04397ea into ms-iot:develop Jan 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants