Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Disabling infiltrate_lwp() for LWP>=5.822: For details, see
  • Loading branch information
mschilli committed Dec 10, 2008
1 parent dc791cf commit 0aa28af
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
4 changes: 4 additions & 0 deletions Changes
Expand Up @@ -8,6 +8,10 @@
range" problem caused by an unbalanced SEM_UNDO when
incrementing it. Reported by John Little.
* (ms) Added parameters in curly braces to cspecs in PatternLayout.
* (ms) As explained in http://rt.cpan.org/Ticket/Display.html?id=41505
the latest LWP release (5.822) got rid of all of its internal
debugging functions, making infiltrate_lwp() and its test
case useless. Disabling it for LWP>=5.822.

1.19 (2008/10/22)
* (ms) Applied patch by Peter Rabbitson, which fixes the caller()
Expand Down
4 changes: 3 additions & 1 deletion lib/Log/Log4perl.pm
Expand Up @@ -2449,7 +2449,9 @@ A call to C<Log::Log4perl-E<gt>infiltrate_lwp()> does exactly this.
In a very rude way, it pulls the rug from under LWP::UserAgent and transforms
its C<debug/conn> messages into C<debug()> calls of loggers of the category
C<"LWP::UserAgent">. Similarily, C<LWP::UserAgent>'s C<trace> messages
are turned into C<Log::Log4perl>'s C<info()> method calls.
are turned into C<Log::Log4perl>'s C<info()> method calls. Note that this
only works for LWP::UserAgent versions E<lt> 5.822, because this (and
probably later) versions miss debugging functions entirely.
=item Suppressing 'duplicate' LOGDIE messages
Expand Down
5 changes: 3 additions & 2 deletions t/048lwp.t
Expand Up @@ -11,11 +11,12 @@ use Test::More;
BEGIN {
eval {
require LWP::UserAgent;
die "Skip tests" if $LWP::UserAgent::VERSION < 2.0;
die "Skip tests" if $LWP::UserAgent::VERSION < 2.0;
die "Skip tests" if $LWP::UserAgent::VERSION >= 5.822;
};

if($@) {
plan skip_all => "Only with LWP::UserAgent 2.0";
plan skip_all => "Only with 2.0 < LWP::UserAgent < 5.822 ";
} else {
plan tests => 3;
}
Expand Down

0 comments on commit 0aa28af

Please sign in to comment.