Implement text annotation, inherits from Text #2687
Conversation
|
Need to remove the include of annotation.h from segment.cpp and scoreview.cpp |
| @@ -376,6 +376,7 @@ class Score : public QObject, public ScoreElement { | |||
| QString _layerTagComments[32]; | |||
| QList<Layer> _layer; | |||
| int _currentLayer { 0 }; | |||
| int _isAnnotation { 0 }; | |||
There was a problem hiding this comment.
I don't see a reason why this shouldn't be done the same as all other similar tester functions - see element.h, the CONVERT macros.
Actually, I take that back. I don't understand this at all. You are defining an annotation to be an entire score?
There was a problem hiding this comment.
No, I'm just setting a flag for the paintevent to check if a box has to be drawn. It could rather have been called "hasAnnotation". See my comment below.
|
To add a hard coded box to the score, select a note, Add->Annotation->RangeAnnotation. |
|
rebase needed |
|
The branch RangeAnnotation1 includes these commits as well On Wed, Jul 6, 2016 at 8:03 PM, Joachim Schmitz notifications@github.com
Ruchit Agrawal. |
|
You mean #2714, right? |
|
Yes, wonder why the check is failing though. On Fri, Jul 8, 2016 at 11:38 AM, Joachim Schmitz notifications@github.com
Ruchit Agrawal. |
|
because there have been some changes to the same code since? |
|
yes, i guess, I shall rebase On Sat, Jul 9, 2016 at 7:50 PM, Joachim Schmitz notifications@github.com
Ruchit Agrawal. |
|
See #2783 |
This branch implements an alternative approach, where text annotation inherits from Text rather than Element.