Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation for instrument list #33

Merged
merged 7 commits into from Aug 8, 2012
Merged

German translation for instrument list #33

merged 7 commits into from Aug 8, 2012

Conversation

Jojo-Schmitz
Copy link
Contributor

Not complete, but no worse than the 1.2 version

Not complete, but no worse than the 1.2 version
@wschweer
Copy link
Contributor

wschweer commented Aug 6, 2012

I changed the encoding of the file from iso-??? to utf8. Did you copy&paste the strings from the old german file?
The "umlaute" look strange in the diff.

@Jojo-Schmitz
Copy link
Contributor Author

Yes, mostly copy and paste from the 1.2 instruments_de.xml, except for "Flöte", which I took from within the new insttruments_de.xml. And I used gvim for Windows to make those changes.

@Jojo-Schmitz
Copy link
Contributor Author

I believe I've now fixed the Umlaute problem, should I close this pull request and sumite a new one?

wschweer added a commit that referenced this pull request Aug 8, 2012
German translation for instrument list
@wschweer wschweer merged commit dddf660 into musescore:master Aug 8, 2012
@lasconic
Copy link
Contributor

lasconic commented Aug 8, 2012

There is probably something to do to avoid the 7 "Merge remote-tracking branch 'upstream/master'" commits next time. Or Jojo should rebase his changes on top of the upstream branch instead of merge. Or we should pull is request locally and fix the history. That will probably broken Jojo repo though...

@Jojo-Schmitz
Copy link
Contributor Author

OK, Werner seems to have accepted the pull request and my repo survived ;-)

I’ve just made some more changes to that file, so let me submit a new pull request…

Bye, Jojo

From: Nicolas Froment [mailto:notifications@github.com]
Sent: Wednesday, August 08, 2012 2:04 PM
To: musescore/MuseScore
Cc: Joachim Schmitz
Subject: Re: [MuseScore] German translation for instrument list (#33)

There is probably something to do to avoid the 7 "Merge remote-tracking branch 'upstream/master'" commits next time. Or Jojo should rebase his changes on top of the upstream branch instead of merge. Or we should pull is request locally and fix the history. That will probably broken Jojo repo though...


Reply to this email directly or view it on GitHub #33 (comment) .

Beschreibung: Das Bild wurde vom Absender entfernt.

Xmader added a commit to Xmader/MuseScore that referenced this pull request Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants