New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
German translation for instrument list #33
Conversation
Not complete, but no worse than the 1.2 version
I changed the encoding of the file from iso-??? to utf8. Did you copy&paste the strings from the old german file? |
Yes, mostly copy and paste from the 1.2 instruments_de.xml, except for "Flöte", which I took from within the new insttruments_de.xml. And I used gvim for Windows to make those changes. |
I believe I've now fixed the Umlaute problem, should I close this pull request and sumite a new one? |
German translation for instrument list
There is probably something to do to avoid the 7 "Merge remote-tracking branch 'upstream/master'" commits next time. Or Jojo should rebase his changes on top of the upstream branch instead of merge. Or we should pull is request locally and fix the history. That will probably broken Jojo repo though... |
OK, Werner seems to have accepted the pull request and my repo survived ;-) I’ve just made some more changes to that file, so let me submit a new pull request… Bye, Jojo From: Nicolas Froment [mailto:notifications@github.com] There is probably something to do to avoid the 7 "Merge remote-tracking branch 'upstream/master'" commits next time. Or Jojo should rebase his changes on top of the upstream branch instead of merge. Or we should pull is request locally and fix the history. That will probably broken Jojo repo though... — Beschreibung: Das Bild wurde vom Absender entfernt. |
Not complete, but no worse than the 1.2 version