New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing InvariantCulture on Parse methods #29
Conversation
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
Thanks, I already did that yesterday |
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
Hi guys, |
@effyteva Reopening and looking into it. |
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
I've already done that... |
@effyteva : please ignore the last bot entry - it's an automatic response to reopening the request |
Thanks Omer, I've received a confirmation from the Lenka - I now have a valid OCA |
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it |
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Hi guys, Thanks, |
@effyteva Sorry for the late reply |
Hi,
The InvariantCulture is critical when parsing values (which MySql Connector does internally), as the Culture depends on the OS (or on the ICU package when using .NET Core on Linux).
I've noticed the fixed had already been applied to Int32, but not for all DataTypes.
Hope this could be merged quickly.
Thanks,
Effy