Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing InvariantCulture on Parse methods #29

Closed
wants to merge 2 commits into from
Closed

Missing InvariantCulture on Parse methods #29

wants to merge 2 commits into from

Conversation

effyteva
Copy link

Hi,
The InvariantCulture is critical when parsing values (which MySql Connector does internally), as the Culture depends on the OS (or on the ICU package when using .NET Core on Linux).
I've noticed the fixed had already been applied to Int32, but not for all DataTypes.

Hope this could be merged quickly.

Thanks,
Effy

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@effyteva
Copy link
Author

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

Thanks, I already did that yesterday

@mysql-oca-bot
Copy link

Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed.
Thanks

@effyteva
Copy link
Author

Hi guys,
Your bot seems to be off...
I have replied, and signed the OCA...

@effyteva
Copy link
Author

@mysql-oca-bot

@mysql-admin
Copy link

@effyteva Reopening and looking into it.
Thank you for submitting
==Omer

@mysql-admin mysql-admin reopened this Jan 21, 2019
@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@effyteva
Copy link
Author

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

I've already done that...
Re-sent it now

@mysql-admin
Copy link

@effyteva : please ignore the last bot entry - it's an automatic response to reopening the request
==Omer

@effyteva
Copy link
Author

@effyteva : please ignore the last bot entry - it's an automatic response to reopening the request
==Omer

Thanks Omer, I've received a confirmation from the Lenka - I now have a valid OCA

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@effyteva
Copy link
Author

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=94045 for updates.
Thanks

@effyteva
Copy link
Author

Hi guys,
Any chance this will be merged anytime soon?
The issue causes the MySQL library to break migrating from Windows to Docker (Linux) instances.
We're still using a custom build for ~3 months now...

Thanks,
Effy

@mysql-admin
Copy link

@effyteva
We are still evaluating - this will either make it to the next release or the one after

Sorry for the late reply
==Omer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants