Skip to content

Configurable compression level for archive storage engine #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Configurable compression level for archive storage engine #217

wants to merge 2 commits into from

Conversation

gc-code
Copy link

@gc-code gc-code commented Aug 5, 2018

I have added a system variable that allows the user to configure the compression level used by the archive storage engine. This was listed as one of Brian's TODOs and I think it would make a nice addition to the engine. Find below a comparison of the ARZ file sizes for different values of 'archive_compression_level' generated by the windows 'dir' command:

05/08/2018  12:04         4,259,928 10_employees.ARZ     :: Compression level 10 (max)
05/08/2018  12:18         4,816,984 0_employees.ARZ      :: Zlib default compression
05/08/2018  12:12         9,076,827 1_employees.ARZ      :: No compression

The prefixed number is the compression level. I have shifted Zlib's default compression levels up by one because the variable list doesn't support signed integers. For example, the default compression level is now 0 instead of -1.

I intend on continuing to work on TODOs around the code if you like what I have done here. Constructive feedback is appreciated.

Thanks,
George

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@gc-code
Copy link
Author

gc-code commented Aug 9, 2018

OCA submitted

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@gc-code
Copy link
Author

gc-code commented Aug 11, 2018

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=91996 for updates.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants