made RSS links absolute URLs [#4 state:resolved]

nakajima · Jul 30, 2008 · 2b8d828 · 2b8d828
1 parent faf1ae6
commit 2b8d828
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -71,13 +71,10 @@ def host_helper
 
   def feed_url_for(post)
     case post
-    when Article
-      post.from_feed? ? post.permalink : url_for(post)
-    when Tweet
+    when Tweet, Link
       post.permalink
-    when Link
     else
-      url_for(post)
+      post.from_feed? ? post.permalink : "http://#{host_helper}#{url_for(post)}"
     end
   end
 

diff --git a/app/models/post.rb b/app/models/post.rb
@@ -22,6 +22,10 @@ def name
     header
   end
 
+  def from_feed?
+    !!feed_id && (feed_id != 0)
+  end
+
   def type
     attributes['type']
   end

diff --git a/app/models/posts/article.rb b/app/models/posts/article.rb
@@ -17,10 +17,6 @@ def allow_comments?
     feed_id.nil?
   end
 
-  def from_feed?
-    !!feed_id && (feed_id != 0)
-  end
-
   def link(root='')
     from_feed? ? permalink : super
   end