Make raw paths absolute #1353
Merged
Make raw paths absolute #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
absolute-raw-paths
branch
2 times, most recently
from
351e7fa
to
c34f007
Compare
denisdefreyne
force-pushed
the
absolute-raw-paths
branch
from
c34f007
to
fe6acf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all raw paths absolute. The dependency on the current working directory still exists, but will be removed in the future. The dependency on the current working directory is much more explicit now, which should help in preventing issues where the current working directory might change during compilation.
This will likely help with #1338.