Teardown listeners after compile #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I added a test case. @bobthecow Review and merge. |
|
👍 |
bobthecow
added a commit
that referenced
this pull request
Apr 7, 2013
…mpile Teardown listeners after compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compilation listeners (diff generator, file action printer, …) are not shut down after compilation has finished. This causes the teardown actions not to be called, which causes problems:
output.diffis sometimes not generated correctly (output.diff not always generated; possibly a threading issue #225)The
max_filter_name_lengthchange was necessary because themax_filter_name_lengthvariable is not actually defined. D’oh!I am not sure how to test this properly. Ideas are welcome!