Allow lowercase environment variables in UTF-8 check #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not a Ruby programmer, but this looks like it will fix it. 👍 |
| @@ -184,7 +184,7 @@ def self.setup_cleaning_streams | |||
| def self.enable_utf8?(io) | |||
| return true if !io.tty? | |||
|
|
|||
| %w( LC_ALL LC_CTYPE LANG ).any? { |e| ENV[e] =~ /UTF/ } | |||
| %w( LC_ALL LC_CTYPE LANG ).any? { |e| ENV[e] =~ /UTF/i } | |||
There was a problem hiding this comment.
do we have to worry about utf16 and other dumb things like that?
denisdefreyne
added a commit
that referenced
this pull request
Oct 3, 2013
Allow lowercase environment variables in UTF-8 check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the nanoc CLI recognise UTF-8 support in the terminal as available when
LC_ALL,LC_CTYPEorLANGcontain the lowercaseutfinstead of only the uppercaseUTF.Fixes #335.