Make XSL filter transform the item, not the layout - issue #399 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the XSL filter used the value of the "content" parameter passed to the "run" method as the content to transform. But when invoked as a layout, filters are passed the content of the _layout_ in this parameter, not the content of the item. As this filter can only be invoked as a layout it did not work as expected. This change modifies the filter to use the value of the ":content" parameter passed to the class at initialization as the content to transform, consistent with how layouts are invoked. It also updates the filter's test cases to reflect how the filter is actually used and to ensure the correct input is being transformed.
|
Cool stuff! |
denisdefreyne
added a commit
that referenced
this pull request
Mar 15, 2014
…tem-content Make XSL filter transform the item, not the layout - issue #399
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #399, "XSL filter transforms the stylesheet's (layout's) content, not the item's".
Previously the XSL filter used the value of the "content" parameter passed to the "run" method as the content to transform. But when invoked as a layout, filters are passed the content of the layout in this parameter, not the content of the item. As this filter can only be invoked as a layout it did not work as expected.
This change modifies the filter to use the value of the ":content" parameter passed to the class at initialization as the content to transform, consistent with how layouts are invoked. It also updates the filter's test cases to reflect how the filter is actually used and to ensure the correct input is being transformed.