Metadata not in correct format - in v3.7.2 only

[sueyacoub]

(IMO) ever since this commit,

We are getting the following runtime error:
The file #{content_filename} appears to start with a metadata section (three or five dashes at the top) but it does not seem to be in the correct format.

We use yaml headers on each page, and they are in the format:
---
filename: <fileame>
<custom-layout-type>: <layout-name>
---

We haven't changed how the metadata headers are formatted. Has anything changed in how the yaml header / metadata should be formatted?

To avoid this error, we have had to set the nanoc version in the gemfile to 3.7.1 and uninstall version 3.7.2 of the nanoc gem from our local machines.

Thanks in advance.

[gpakosz]

Has anything changed in how the yaml header / metadata should be formatted?

Yes, #463 changed the way content is separated from metadata. However, we didn't notice any regression when running the tests.

Could you please copy paste the exact content of the offending file? Or ideally upload the offending file somewhere?

[Fjan]

It fails on any file that has \r\n line endings instead of \n line endings. I narrowed down the problem to this regex that is new in 3.7.2:

   pieces = data.split(/^(-{5}|-{3})[ \t]*\n/)

One way to fix it would be:

   pieces = data.split(/^(-{3,5})[ \t]*\r?\n/,5)

Note that the last parameter to split limits the number of pieces so there is no need to join them later, which could potentially mess up a file that has '---' somewhere in the middle.

[gpakosz]

@Fjan please see my comments on #471.

[kraftkern]

Hi @gpakosz,

i have this error all over the place, but in files that actually have NO CONTENT. I.e. files with metadata but no content part. This worked great in previous versions and I have lots of files like that :) This is much needed feature I always used.

[gpakosz]

@kraftkern we believe we identified the regression, can you confirm your files are in CR-LF mode? (dos encoding)

[kraftkern]

hey @gpakosz ! Thanks for quick reply. No, can't confirm that. All files are UTF-8 with LF-only (I'm working on a mac). Are they supposed to be CR-LF?

[kraftkern]

Here's an example (full content with all new lines):

P.S.: i got the site working again with nanoc 3.6.1

[gpakosz]

@kraftkern reproduced and fixed it in the PR. Thank you.

[denisdefreyne]

Fixed in #471 (3.7.3).