Do not upload files with identical etags #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
added
type:enhancement ✨
to review
status:wip 🔧
and removed
to review
labels
denisdefreyne
force-pushed
the
aws-deploy-md5-v2
branch
from
6f7752d
to
bfb34eb
Compare
denisdefreyne
force-pushed
the
aws-deploy-md5-v2
branch
from
bfb34eb
to
c25a153
Compare
denisdefreyne
added a commit
that referenced
this pull request
May 31, 2015
Do not upload files with identical etags
|
Got a +1 before the extra tests, so I’m assuming that’s fine now too. I tested it and it works anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continued off #480. Replaces #536 (code identical, but this time on
masterinstead ofrelease-3.7.x).This PR has quite a bit of extra tests and refactorings that make these tests possible. I also tested this with an actual S3 and can confirm that it works.