Fix final :pre snapshot not being generated #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
fix-pre-snapshot
branch
from
e2fd777
to
84f5ead
Compare
denisdefreyne
added a commit
that referenced
this pull request
Dec 11, 2015
Fix final :pre snapshot not being generated
|
Unfortunately, while using
|
|
Ack—I guess that’s why it’s still in beta :). Lesson learnt for me: when fixing a bug, try the original test case again to make sure the right bug is tackled. I’ll reopen the original issue and look into it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
:presnapshot is not generated properly (it remains “non-final”). This PR fixes that.The
NonFinalSnapshotWithPathErrorerror might need to be removed. I’ll try to keep it in (it’s useful) but getting it to work properly might be hard.Fixes #762.