Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprocessor not executed before check #841

Closed
francois2metz opened this issue Mar 24, 2016 · 4 comments
Closed

Preprocessor not executed before check #841

francois2metz opened this issue Mar 24, 2016 · 4 comments
Labels
type:bug 🐛
Milestone
4.1.5

Comments

@francois2metz
Copy link

The fix in #784 have been removed in #788.

Dynamic items created in the preprocess block are marked as stale.

To fix it, I added site.compiler.action_provider.preprocess(site) in lib/nanoc/cli/commands/check.rb.

I can open a pull request if you think it is the right fix.
@denisdefreyne
Copy link
Member

You’re right—#788 should’ve kept the preprocessing step before checks.

Your suggestion seems correct. I’ll implement the fix and add a regression spec.

@denisdefreyne denisdefreyne added this to the 4.1.5 milestone Mar 24, 2016
@denisdefreyne denisdefreyne mentioned this issue Mar 24, 2016
Merged
@denisdefreyne
Copy link
Member

Fix in #842.

@francois2metz
Copy link
Author

Thanks!

@denisdefreyne
Copy link
Member

This is released in 4.1.5 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug 🐛
Projects
None yet
Milestone
4.1.5
Development

No branches or pull requests
2 participants
@denisdefreyne @francois2metz