Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to customize ncy-breadcrumb-last #123

Closed
freethejazz opened this issue Jan 22, 2016 · 5 comments
Closed

No way to customize ncy-breadcrumb-last #123

freethejazz opened this issue Jan 22, 2016 · 5 comments

Comments

@freethejazz
Copy link
Contributor

I noticed this when attempting to enable a custom template that binds html, like the example in the documentation. When using the ncy-breadcrumb-last directive, the label shows all of the escaped markup because the directive is hard-coded to use '{{ncyBreadcrumbLabel}}' (https://github.com/ncuillery/angular-breadcrumb/blob/master/src/angular-breadcrumb.js#L242). This greatly limits the ability to use both ncy-breadcrumb-last and custom templates together.

@freethejazz
Copy link
Contributor Author

I think the simplest approach for dealing with this is to implement options for lastTemplate and lastTemplateUrl that work similar to the way template and templateUrl work now. I'd be happy to take a cut at this if that approach seems reasonable.

@ncuillery
Copy link
Owner

Hi,

You are right, ncyBreadcrumbLast is less flexible than ncyBreadcrumb and I can't find workaround for this case.

Your approach seems legit to me 👍

@ncuillery ncuillery reopened this Jan 25, 2016
@ncuillery
Copy link
Owner

Ooops miss click

@freethejazz
Copy link
Contributor Author

Great! I'll throw a PR your way in the next few days

@freethejazz
Copy link
Contributor Author

Haven't forgotten about this. #114 complicates this issue a bit, so I may knock that one out first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants