New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why href
and not ui-sref
#54
Comments
I didn't think about that when I started designing the module :) I'm asking myself about include the refactoring the template in the next minor release (0.4.0). I keep the issue open. Nevertheless, even with
|
Ive updated to ui-router: 0.2.13 works as expected now without page-reload, thanks decorating the template is also a easy solution app.config(function($breadcrumbProvider) {
$breadcrumbProvider.setOptions({
template:
'<div class="breadcrumb">' +
'<a ng-repeat="step in steps" class="btn btn-flat" ui-sref="{{step.name}}" ng-disabled="$last">{{step.ncyBreadcrumbLabel}}</a>' +
'</div>'
});
}); |
I keep the issue open (to keep in mind the refactoring of the template). Please, can you give me your old versions of dependencies ? (I would like to know if there is a general problem with a specific set of versions) |
Sorry to say but i dont have the old dep-list. This project was versioned after the update. |
It is still relevant to implement the use of ui-sref instead of href. ncyBreadcrumb: { Or am I missing something here? |
This still NOT working?! ncyBreadcrumb: {
parent: function($scope){ return 'show({id: ' + $scope.itemId+ '})'; },
label: 'Details'
} I have the same need! |
That's because I DON'T have time to investigate and fix it. Fortunately, PR are welcome. |
Oh i see, make sense. Your work is great! |
@aragao-diego It's not working because the state.name is already parsed into state name without params. For example, passing "show({id: 3})" will be parsed as "show" as the step.name. @ncuillery you could add conf.ncyBreadcrumbState = stateRef; inside $$addStateInChain function. |
I made a Pull Request for this. Hope you can review it. |
@ncuillery Is the feature added by @kiddo13 merged with main branch? |
@AnirudhaGohokar Yes 😄 The fix has been merged (release pretty soon) and I addressed the template enhancement in #142. |
What is the reason to use
href
and notui-sref
within the templates? Leads to a page-reload for me.The text was updated successfully, but these errors were encountered: