Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/browse tags #91

Closed
wants to merge 39 commits into from

Conversation

JorgenSolli
Copy link
Contributor

Added the option for users to browse tags, without having to search for them.

I'm sure there will be some feedback with wanted changes before this is merged, but for now; this is a working 'prototype'

Preview:
image
image
image

@emodric
Copy link
Member

emodric commented Jan 16, 2019

This looks quite good, thank you!

However, just as with #90, it needs to go to 3.3-release branch :)

@JorgenSolli JorgenSolli changed the base branch from master to 3.3-release January 16, 2019 14:27
@JorgenSolli
Copy link
Contributor Author

This looks quite good, thank you!

However, just as with #90, it needs to go to 3.3-release branch :)

Hi, @emodric
No worries. I have changed the target branch now on both PRs :)

@emodric
Copy link
Member

emodric commented Jan 16, 2019

You will also need to rebase your commits to 3.3 branch, since now the PR shows a complete mess of your commits and mine from the master branch.

@emodric
Copy link
Member

emodric commented Jan 16, 2019

The easiest way would be to cherry pick your commits one by one to a new branch created from 3.3-release and then force push to your feature/browse-tags branch on GitHub.

@JorgenSolli
Copy link
Contributor Author

You're right! What a mess 😁
I'll get this done sometime this week!

@JorgenSolli JorgenSolli mentioned this pull request Mar 22, 2019
@emodric
Copy link
Member

emodric commented Apr 2, 2019

Replaced by #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants