From 5550ca4cfe47e8261008781d8ce1a3a793b060a8 Mon Sep 17 00:00:00 2001 From: Avi Kelman Date: Fri, 2 Jan 2015 21:55:57 -0500 Subject: [PATCH 1/2] document the triggered line in error messages the triggered line is critical information when determining failure root cause --- doc.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc.cpp b/doc.cpp index 430fdd00..4e91aafd 100644 --- a/doc.cpp +++ b/doc.cpp @@ -2622,8 +2622,8 @@ void CMUSHclientDoc::ExecuteTriggerScript (CTrigger * trigger_item, return; CString strType = "trigger"; - CString strReason = TFormat ("processing trigger \"%s\"", - (LPCTSTR) trigger_item->strLabel); + CString strReason = TFormat ("processing trigger \"%s\" on line \"%s\"", + (LPCTSTR) trigger_item->strLabel, (LPCTSTR) strCurrentLine); // get unlabelled trigger's internal name const char * pLabel = trigger_item->strLabel; From 9bf5138faf2c6986c9f500becf476837fd5ef9f3 Mon Sep 17 00:00:00 2001 From: Nick Gammon Date: Wed, 7 Jan 2015 13:30:35 +1100 Subject: [PATCH 2/2] Reworded error message slightly --- doc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc.cpp b/doc.cpp index 4e91aafd..802b5257 100644 --- a/doc.cpp +++ b/doc.cpp @@ -2622,7 +2622,7 @@ void CMUSHclientDoc::ExecuteTriggerScript (CTrigger * trigger_item, return; CString strType = "trigger"; - CString strReason = TFormat ("processing trigger \"%s\" on line \"%s\"", + CString strReason = TFormat ("processing trigger \"%s\" when matching line: \"%s\"", (LPCTSTR) trigger_item->strLabel, (LPCTSTR) strCurrentLine); // get unlabelled trigger's internal name