nloko / banshee-telepathy-extension

[Debug 20:47:34.516] Getting download with key /org/bansheeproject/MetadataProvider_3 [Debug 20:47:34.516] Key found [Debug 20:47:34.516] UpdateDownload: expected 2532 downloaded 2250 [Debug 20:47:37.475] TrackInfoDisplay RenderAnimation: 32.00 FPS [Debug 20:47:37.475] TrackInfoDisplay RenderAnimation: 32.00 FPS banshee_test1@jabber.org detected Tube closing
[Debug 20:47:40.739] Detected closing tube, so cleaning up data for banshee_test1@jabber.org [Debug 20:47:40.813] resetting downloads Banshee.Telepathy.API.Dispatchables.DBusActivity with key org.bansheeproject.MetadataProviderService removed from DM

DBus tubes seem to randomly close. Happens a lot during library download and the contact on the other end will not get notified that the tube is gone.

OnAvatarRetrieved handle 9 token 8073c8b byte.length 1687 type image/jpeg
OnAvatarRetrieved handle 9 token 8073c8b byte.length 1687 type image/jpeg
OnAvatarRetrieved handle 9 token 8073c8b byte.length 1687 type image/jpeg
OnAvatarRetrieved handle 9 token 8073c8b byte.length 1687 type image/jpeg
OnAvatarRetrieved handle 9 token 8073c8b byte.length 1687 type image/jpeg
OnAvatarRetrieved handle 9 token 8073c8b byte.length 1687 type image/jpeg
OnAvatarRetrieved handle 9 token 8073c8b byte.length 1687 type image/jpeg
OnAvatarRetrieved handle 9 token 8073c8b byte.length 1687 type image/jpeg
OnAvatarRetrieved handle 9 token 8073c8b byte.length 1687 type image/jpeg

I want libnotify bubbles when:
An "always approved" (see issue 15) contact connects to me A contact's library (to which I am connected) disappears for whatever reason, especially if I'm currently downloading/streaming from them * There is a new connection approval request

This last case is the biggest change. I do not like the pop-up window. It shows up out of nowhere, and if I'm currently typing I can easily accidentally press a key to dismiss it before I even realize it's there. I would assume that most users have Banshee running in the background in some way (behind the current app window, or minimized, or on a different desktop). The chances of Banshee being their active window is super-low, so the pop-up is a HUGE flow interrupter. It should be replaced with a libnotify bubble.

When using a notification daemon that supports actions (everybody but Ubuntu), there should be buttons in the bubble to approve or deny. When using a notification daemon that does not support actions, clicking the notification should bring Banshee to the front.

Regardless of notification daemon, a yellow infobar thingy (like in Firefox) should slide into the Banshee UI with the same information as the notification bubble. This is a nice UI if you are already actively using Banshee or if you choose to ignore the bubbles at first. There should be a bar for each pending request, and it should include the approve/deny buttons. Obviously that may not scale for dozens of requests, so this might not be the perfect UI either.

Still, by no means should you be interrupted in your work/play/porn because a contact wants to browse your library. Their need cannot be as desperate as yours.

The current Contacts source shows a big useless lists of contacts. It can't be sorted or searched, and no actions can occur on the contacts, and most of them won't have the banshee extension installed, so it's just noise.

Instead, I propose that the Contacts source show:
1) Who is connected to you, and what they are listening to (listening history available, too?), with the ability to disconnect them and deny them future access
2) Though it's redundant, a list of which of your contacts have libraries available for browsing, and some indicator if you are connected to them, along with stats about the library (x songs, y playlists, z listens by you...most popular track among other sharers, blah blah blah). I think on the whole this overview is nice; maybe even more pleasant than the tree view. You should be able to click on a contact to get to their library.

This whole thing would probably look prettiest if it copied the Last.fm source UI or something.

I should be able to share everything by default, but be able to specify certain playlists and tracks that I don't want to share.

I should be able to share nothing by default, but be able to specify certain playlists and tracks that I do want to share.

I should be able to use smart playlists to control this.

Using gabble 0.9.2.

Steps to reproduce:
1) Browse a contact A's library
2) Stream music
3) Pause streaming
4) After a few minutes, resume streaming
5) Playback will not resume until contact A's presence is online

This was not a problem with previous versions of gabble. Must investigate and possibly open a bug with Telepathy.

Right-click a contact and selecting 'Cancel Browse Request' will cancel the outstanding request with the selected contact, if one exists. However, if the accept dialog is open on the other side of the request, it will not close. See https://bugs.freedesktop.org/show_bug.cgi?id=22337

Transfer speeds are highly dependant on the Telepathy framework's ability to establish a P2P connection. If traffic goes through Jabber servers, be prepared for a highly sluggish experience. See https://bugs.freedesktop.org/show_bug.cgi?id=22930

If my friend has Banshee open while he sleeps, and I restart my own Banshee, I'd like to be able to reconnect to his share without him having to do anything (if he deems this okay). Also, if I have an abusive jerk on my contact list, I'd like to be able to automatically refuse them without dealing with a pop-up.

So, when approving/denying a connection, there should be an option to always approve/deny, reducing the amount of work you have to do.

After fixing a similar bug in the new eMusic extension, I noticed that if the "Copy files to media folders when importing" is not set, tracks are imported directly from the download folder under .cache.

This patch should fix this (yes I'm too lazy to do it with a fork/merge, and I can't attach a file to the issue):

From <a href="/nloko/banshee-telepathy-extension/commit/e38f4c0408e29df1d46bb988f5f74a8cbc7b05b2">e38f4c0</a> Mon Sep 17 00:00:00 2001
From: Bertrand Lorentz <bertrand.lorentz@gmail.com>
Date: Sat, 9 Jan 2010 17:52:36 +0100
Subject: [PATCH] Always copy downloaded tracks to the library

If the "Copy files to media folders when importing" was not set, tracks
would be imported directly from the download folder under .cache.
Create and use a new instance of LibraryImportManager as a private
field that always copies tracks to the library folder.
---
 src/Banshee.Telepathy.Gui/DownloadManagerUi.cs |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/Banshee.Telepathy.Gui/DownloadManagerUi.cs b/src/Banshee.Telepathy.Gui/DownloadManagerUi.cs
index 54b8d9b..fb7f1f4 100644
--- a/src/Banshee.Telepathy.Gui/DownloadManagerUi.cs
+++ b/src/Banshee.Telepathy.Gui/DownloadManagerUi.cs
@@ -43,12 +43,15 @@ namespace Banshee.Telepathy.Gui
     {
         private TelepathyService service = null;
         private readonly TelepathyDownloadManager download_manager = new TelepathyDownloadManager ();
+        private Banshee.Library.LibraryImportManager import_manager = null;

         public DownloadManagerUi (TelepathyService service) : base ()
         {
             this.service = service;
             Title = Catalog.GetString ("Download(s) from Contacts");
             CancelMessage = Catalog.GetString ("Downloads are in progress. Would you like to cancel them?");
+            
+            import_manager = new Banshee.Library.LibraryImportManager (true);

             download_manager.Updated += OnUpdated;
             download_manager.Completed += OnCompleted;
@@ -71,8 +74,6 @@ namespace Banshee.Telepathy.Gui

         private void ImportTrack (string path)
         {
-            Banshee.Library.LibraryImportManager import_manager = ServiceManager.Get <Banshee.Library.LibraryImportManager> ();
-
             if (import_manager.ImportTrack (path) != null) {
                 import_manager.NotifyAllSources ();
             }
-- 
1.6.4.4