@@ -1,3 +1,8 @@ +2008-08-1 Norman Clarke <norman@randomba.org> + + * Fixed a bug where overwriting a previous image triggered callbacks more + than once, causing errors. + 2008-07-29 Norman Clarke <norman@randomba.org> * Downcased generated file names to avoid potential issues on CHANGELOG @@ -1,7 +1,7 @@ Gem::Specification.new do |s| s.name = "has_image" - s.version = "0.1.5" - s.date = "2008-07-29" + s.version = "0.1.6" + s.date = "2008-08-01" s.add_dependency('mini_magick', '>= 1.2.3') s.rubyforge_project = 'has-image' s.summary = "Lets you attach images with thumbnails to active record models." has_image.gemspec @@ -210,10 +210,17 @@ module HasImage # Deletes the image from the storage. def remove_images return if has_image_file.blank? - storage.remove_images(self.id) - update_attribute(:has_image_file, nil) - rescue Errno::ENOENT - logger.warn("Could not delete files for #{self.class.to_s} #{to_param}") + self.class.transaction do + begin + # Resorting to SQL here to avoid triggering callbacks. There must be + # a better way to do this. + self.connection.execute("UPDATE #{self.class.table_name} SET has_image_file = NULL WHERE id = #{id}") + self.has_image_file = nil + storage.remove_images(self.id) + rescue Errno::ENOENT + logger.warn("Could not delete files for #{self.class.to_s} #{to_param}") + end + end end # Creates new images and removes the old ones when image_data has been lib/has_image.rb 703760e4bbf15ffad3a4ce0a6670355482f6693c Norman Clarke norman@addthree.com http://github.com/norman/has_image/commit/52bfffe2cc0947400efe31f342689835967a19f5 52bfffe2cc0947400efe31f342689835967a19f5 2008-08-01T08:26:44-07:00 2008-08-01T08:26:44-07:00 Fixed a bug where overwriting a previous image triggered callbacks more than once, causing errors. d08dde25917161ee919d67341d1f721e7c2b2673 Norman Clarke norman@addthree.com