New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory allocation issue in ime.cpp #3234
Comments
Comment 1 by jteh on 2013-05-14 23:16 Mick, should this be fixed for 2013.1 or is this too risky at this stage? |
Comment 2 by mdcurran on 2013-05-27 02:06 |
Attachment 3234_IMELen.patch added by mdcurran on 2013-05-27 02:08 |
Comment 3 by jteh on 2013-05-28 07:10 |
Comment 4 by nishimotz on 2013-05-28 13:02 With Windows XP and ATOK 2013 (Japanese input method), garbage announce still occurs when focus is moving around the Windows start menu items. The cand_str should be allocated for the sum of actual string lengths of candidates. |
Comment 5 by mdcurran on 2013-05-28 20:04 |
Comment 6 by nishimotz on 2013-05-28 22:48 Even garbage announces are hidden by succeeding announce, they can be seen in speech viewer. |
Comment 7 by mdcurran (in reply to comment 6) on 2013-06-11 00:15
Sorry, on XP for me the installation fails with an unknown IME error or something. |
Comment 8 by mdcurran on 2013-06-11 00:54
If none of those work, can I ask that you add some logging calls so that we can understand what is in the struct. Something like:
|
Attachment nvda-3234-130613.log added by nishimotz on 2013-06-13 04:35 |
Attachment 3234_130613.patch added by nishimotz on 2013-06-13 04:36 |
Comment 9 by nishimotz on 2013-06-13 04:46 According to the log attached above, I agree that the allocated size of cand_str is always larger than the real usage in inputCandidateListUpdate. It should be mentioned that the useless allocations of 16988 bytes are observed (when moving around focus within the explorer) as follows:
|
Comment 10 by mdcurran on 2013-06-13 06:14 |
Comment 11 by nishimotz on 2013-06-13 12:05 |
Attachment 3234_patch3.patch added by mdcurran on 2013-06-13 22:55 |
Comment 12 by mdcurran (in reply to comment 11) on 2013-06-13 22:57
Hmm, its attached now. Sorry about that. It seems it did not attach the first time. Looks like if a description is not provided the file does not attach... or something. |
Comment 13 by nishimotz on 2013-06-14 06:22 No garbage message is observed with ATOK 2013 and Google Japanese Input for both operating systems. Thank you. |
Comment 14 by mdcurran on 2013-06-14 06:25 |
Comment 15 by nishimotz on 2013-06-14 06:47 It should be mentioned that we also worked for NVDAJP (2013.1jp) around #2730 and other issues regarding Japanese input. I will file them later. |
Comment 16 by Michael Curran <mick@... on 2013-06-14 07:06
Changes:
|
Reported by nishimotz on 2013-05-14 13:54
Memory allocation issue in ime.cpp causes irrelevant garbage announces at Windows desktop operations, when IMM-based Japanese input methods are active, such as Google Japanese IME or ATOK.
As in the patch below, malloc(len) is obtaining wrong size of cand_str buffer, and the string may not be initialized if there are no candidates.
The text was updated successfully, but these errors were encountered: