New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add restart option to the exit dialog #4057
Comments
Comment 1 by zahari_bgr on 2014-07-06 02:46 For disabling addons, I've added a command line option --disable-addons and one parameter to core.restart(DisableAddons=False) Another option which could be added in the future for example is "Run pending updates". I've attached a patch (exitWithOptions.diff) and also created a branch named "t4057" in the following repository: |
Comment 2 by jteh on 2014-07-06 08:54 Note that it should be possible (and documented) for this feature to be used when starting NVDA (not just restarting). Since you've implemented it as a command line option, this will work just fine, but the documentatio might need to be updated accordingly. It's possible you've already done this, but in case you haven't before i get to review it, please be sure that this code also disables code loaded from old-style plugins and drivers; i.e. in the directories outside of the addons directory. |
Comment 3 by zahari_bgr on 2014-07-07 19:28 I edited only the description of the Warn before exiting NVDA checkbox in the user guide without entering in many details. |
Comment 4 by jteh on 2014-07-08 06:50 |
Attachment exitWithOptions.diff added by zahari_bgr on 2014-07-09 01:32 |
Comment 5 by zahari_bgr on 2014-07-09 01:37 |
Attachment pendingUpdates.diff added by zahari_bgr on 2014-07-10 19:31 |
Comment 6 by zahari_bgr on 2014-07-10 19:34 What do you think? |
Comment 7 by nvdakor on 2014-07-10 19:45 |
Comment 8 by jteh on 2014-07-11 02:35 |
Comment 9 by jteh on 2014-08-29 07:24 This is really good work. Thanks! Comments: One major UI concern I have is that I (and probably others) am used to pressing NVDA+q and then y for yes. While this is pretty silly (I may as well just disable the dialog if I'm going to do this), it's been like this for years now and this is something one does often enough that one is likely to form solid habits. That said, I can't think of a way to rephrase things so it can be Yes or No, so we might just have to live with this. For consistency, add-ons should be spelled add-ons; note the hyphen. This occurs in your exit dialog, your changes to the Add-ons Manager and your User Guide changes. The option "Show exit options on exiting NVDA" should probably be "Show exit options when exiting NVDA".
nit: The name argument isn't really used for anything, so I'd just remove it.
nit: There's no need for a sizer if it only contains one item and it's inside another sizer.
Change the help message to "Disable all add-ons" or similar. User Guide changes:
Thanks again! |
Comment 10 by zahari_bgr on 2014-09-03 03:41
I've updated my bitbucket fork with this changes - hope I didn't missed something. Thanks, |
Comment 11 by jteh (in reply to comment 10) on 2014-09-03 22:59
Thanks for contributing! :)
Indeed. I thought about some sort of hidden access key, but I think perhaps we'll just leave it as is and see what happens.
Since it's useful, leave it as is.
Leave them; it was more a comment for future reference. It's great that you're striving to be consistent with surrounding code. In the case of ids, I break that rule when I'm writing a new class, but I remain consistent when working with an existing class.
Hmm. Perhaps there could be a message in the Exit dialog saying something like this:
I'm not sure it's worth the effort, since the actual options will always be in English anyway. Also, most users will rarely use --help.
Because some options are meant only for internal use. They might do things that most users won't understand or we might remove or change them at any time. If there were a simple way to do this, I'd prevent them from being shown in --help, but I don't think we can do that.
Fair enough. Leave it as is. So, the only change needed from you is the message in the Exit dialog, but let's wait for Brian's feedback. |
Comment 12 by zahari_bgr on 2014-09-18 23:33 I pushed it to my repository. |
Comment 14 by briang1 on 2014-09-21 12:37 |
Comment 15 by zahari_bgr on 2014-09-21 22:19 |
Comment 16 by blindbhavya on 2014-10-03 12:17 |
Comment 18 by James Teh <jamie@... on 2014-10-08 04:35
Changes:
|
Comment 19 by jteh on 2014-10-08 04:36 |
Comment 20 by nvdakor on 2014-10-08 19:41
SynthName is just a placeholder. |
Comment 21 by jteh (in reply to comment 20) on 2014-10-08 22:39
That's expected and intended. It should revert to using eSpeak. Note that users running release versions won't hear the error sound.
It was done like this to allow users to still see what add-ons they have installed and uninstall problematic ones if necessary. In future, they will probably be able to disable individual add-ons as well. |
Comment 22 by nvdakor on 2014-10-15 05:51
Technical: in GUI, there is no check for a possibility that multiple exit dialogs are opened. A possible fix might be to introduce a Boolean flag in GUI that tells NVDA to show the dialog only once. Another and more easy fix would be to change globalCommands.quit script to show the dialog only when the command was pressed once. |
Comment 23 by James Teh <jamie@... on 2014-10-17 07:15
|
Comment 24 by jteh (in reply to comment 22) on 2014-10-17 07:16
Fixed in 8208da9. Thanks for reporting. |
Comment 25 by James Teh <jamie@... on 2014-11-03 06:15
Changes:
|
Comment 26 by jteh on 2014-11-03 06:16 |
Reported by zahari_bgr on 2014-04-07 03:20
The exit dialog may be enhanced by adding several options:
This could be either seperate buttons for different actions or a combo box for choosing desired option and OK and Cancel buttons.
Blocking #3127
The text was updated successfully, but these errors were encountered: