Add support for BrailleNote QT basic mode #5993
Comments
josephsl
added a commit
that referenced
this issue
May 24, 2016
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Sep 27, 2016
…onary key lookup. re nvaccess#5993 A tip from Jamie Teh (NV Access0: use dict.get to simplify the turnary operation. Also, BNQT ticket is 5993, not 5992, and correct comment text.
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Sep 29, 2016
… gesture identifier right. nvaccess#5993 Comment from Jamie Teh (NV Access): use sets instead of turning that into a list just for formatting purposes (and turns out this is unnecessary).
|
I've been playing around with the BrailleNote QT and thought it might help to let you know that the codes it sends for keys are the Windows Virtual Key Codes |
michaelDCurran
pushed a commit
that referenced
this issue
Jun 13, 2018
* BrailleNote: Support scroll wheel on Apex BT. re #5992 * BrailleNote: Support BrailleNote QT basic mode. re #5993 * BrailleNote: Various BT and QT commands now work correctly. re #5992. Somehow, forgot to check that Rui used a tuple to specify key assignments. Now utilized properly to assign multiple gestures to a command. Also took this time to add codes for various QT keys so NVDA can properly recognize them. * BrailleNote QT: handle QT input directly from read packet function. re #5992 Comment from Jamie Teh (Nv Access): there's no need to call read packet again if we're dealing with QT, so handle this from read packet directly. Thus readPacket returns three things: command, arg (dot mask on BT/command for QT), arg2 (char from QT). * BrailleNote QT: QT key parser refactor. Instead of relying on a dedicated QT key parser, handle parsing directly in readPacket. Also simplifies gesture ID assignment, as the packet will tell the gesture constructor as to what key it is. * BrailleNote QT: comment text change, correct ticket, simplified dictionary key lookup. re #5993 A tip from Jamie Teh (NV Access0: use dict.get to simplify the turnary operation. Also, BNQT ticket is 5993, not 5992, and correct comment text. * User guide: cosmetics. re #5992 Review from Jamie Teh (NV Access): * QT can emulate a BrailleNote BT, hence clarify this. * Removed redundant kcinclude statement. * BrailleNote QT: use set instead of worrying too much about formatting gesture identifier right. #5993 Comment from Jamie Teh (NV Access): use sets instead of turning that into a list just for formatting purposes (and turns out this is unnecessary). * Merge master * Readjust commands * BrailleNote: copyright year update, QT key name changes. Re #5992. Commented by Leonard de Ruijter: rename QT key names. Update copyright years. * BrailleNote: rename scroll wheel constant strings. Re #5992. * Restore executable permission to win32calc
|
Hi, Fixed a critical regression: possibly due to use of HwIO, QT commands were treated as raw strings, so no need to ord this anymore. Thanks. |
josephsl
added a commit
that referenced
this issue
Jun 13, 2018
Perhaps due to HwIO: when processing QT commands (arg2), the argument was a string, not an integer, so ord(arg2) didn't work. Now fixed.
|
@josephsl is this issue still valid? |
|
Hi, let’s close this one. Thanks.
From: Adriani90 <notifications@github.com>
Sent: Sunday, February 24, 2019 11:01 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Add support for BrailleNote QT basic mode (#5993)
@josephsl <https://github.com/josephsl> is this issue still valid?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#5993 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkLSjlhOL4xgK7Q0WUlSuVER_ymoeks5vQuFrgaJpZM4IlXwY> . <https://github.com/notifications/beacon/AHgLkLP_FtjSghQ74Xd81BW2d71nAFQwks5vQuFrgaJpZM4IlXwY.gif>
|
|
ok does this mean the issue is solved? Or you will not work on this in the future. If it's not solved then maybe we can find someone who can continue working on this. Thanks. |
|
Hi, resolved as of 2018.3 (see what’s new for details). Thanks.
From: Adriani90 <notifications@github.com>
Sent: Monday, February 25, 2019 1:27 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Add support for BrailleNote QT basic mode (#5993)
ok does this mean the issue is solved? Or you will not work on this in the future. If it's not solved then maybe we can find someone who can continue working on this. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#5993 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkDbNBXA7AuNNVn9H0tsNpu7pmfkaks5vQ6xIgaJpZM4IlXwY> .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Continuing from #5992:
The below commit (part of i5992 branch) adds support for BrailleNote QT models. There are two modes of operation: basic mode (basic QWERTY commands are available), and PC mode (emulates PC keyboard).
The following commands are available:
On the QT, the names of keys are:
QT commands are based on KeySoft native commands except as noted. Thanks.
The text was updated successfully, but these errors were encountered: