Provide programmatic version information in all of our executables and dlls #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… major, minor, build. Build is conveyed to scons via a version_build argument. AppVeyor uses its own build number for this.
…eeded, plus it is misleading unless it is set with a string specific to each file.
| @@ -30,9 +30,13 @@ controllerRPCHeader,controllerRPCClientSource=env.MSRPCStubs( | |||
|
|
|||
| clientLibName="nvdaControllerClient%s"%('64' if env['TARGET_ARCH']=='x86_64' else '32') | |||
|
|
|||
| rcFile=env.Command('nvda.rc',env['projectRCFile'],Copy('$TARGET','$SOURCE')) | |||
| RESFile=env.RES(rcFile) | |||
There was a problem hiding this comment.
Is there a reason we can't use the same .res file for all of these dlls/exes, rather than having a separate one for each.
|
nvda.rc.subst has been saved as UCS-2 (16 bit), rather than ASCII. Is there any reason for this? It makes it show up as a binary file in GitHub, among other things. |
| @@ -72,9 +72,11 @@ nvdaInProcUtilsRPCHeader,nvdaInProcUtilsRPCServerSource=env.MSRPCStubs( | |||
|
|
|||
| ia2utilsObj=env.Object("./ia2utils","../common/ia2utils.cpp") | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
nit: Extraneous added white space.
|
All good. Incubate away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6204