Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ok button not default button in speech dictionary window #6206

Closed
Qchristensen opened this issue Jul 25, 2016 · 3 comments
Closed

Ok button not default button in speech dictionary window #6206

Qchristensen opened this issue Jul 25, 2016 · 3 comments
Assignees
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone

Comments

@Qchristensen
Copy link
Member

When in NVDA's speech dictionary window, there is no default button. If you are not on a button and press ENTER, nothing happens. You have to TAB to the OK button in order to activate it.

@michaelDCurran michaelDCurran added the p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Jul 25, 2016
@ctoth
Copy link
Contributor

ctoth commented Aug 19, 2016

It seems to me that the only item that is not actually a button in this window is the list, and I would actually expect that pressing enter on an item in the list would bring up the dialog to edit that item, which it does not.

@feerrenrut feerrenrut self-assigned this Aug 22, 2016
@feerrenrut
Copy link
Contributor

Pressing ctrl + enter results in the pending changes being saved and the dialog closing, as if pressing the OK button.

This behaviour currently works in the symbol pronunciation dialog which has a similar pattern. However the pronunciation dialog has had to work around an issue in wx that causes this behaviour (according to the comments, wx ticket #3725). This should be trivial to fix, see onListChar in the SpeechSymbolsDialog class.

feerrenrut added a commit that referenced this issue Aug 23, 2016
Due to a bug in wx (see wx ticket #3725) ListCtrl objects swallow
keypresses (including enter). This is resolved by registering an event
handler and forwarding enter presses to the dialog, and allowing thew
ListCtrl to handle all others.
@feerrenrut
Copy link
Contributor

Thanks @ctoth, you raise a good point there. However, for now I think we will try to keep this work flow consistent with the other dialogs. We are planning on re-working the UI shortly, and we will take this into account during that process.

As a side note, you can press alt+e to edit an item directly.

feerrenrut added a commit that referenced this issue Aug 29, 2016
Fix for issue #6206

Merge remote-tracking branch 'origin/i6206-OKButtonNotDefault' into next
@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Sep 14, 2016
feerrenrut added a commit that referenced this issue Sep 14, 2016
While in the dictionary dialog, pressing the enter key now saves changes and exits. (#6206)
josephsl added a commit to josephsl/nvda that referenced this issue Oct 28, 2016
…access#6520

Specifically:
* nvaccess#5906: Now labeled as 'line indentation reporting'.
* nvaccess#6099: clarify how to change values in spin controls.
* nvaccess#5886: elements list is available in browse mode.
* nvaccess#6206: changed bits such as 'adding new entries'.
* nvaccess#6127: no more hyphen (dash).
* nvaccess#5050: 'causes' -> 'which caused'.
* nvaccess#4164: changed wording to reflect that read-only edit fields are now included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Development

No branches or pull requests

5 participants