Include milliseconds in log timestamps. #7163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it possible to measure response time in logs. We almost always want things to respond faster than one second, so second granularity is useless for this purpose.
feerrenrut
approved these changes
May 11, 2017
Did you mean as a code comment or just on this PR? Here's an example: Without this PR:
With this PR:
|
|
Great, thanks! I did just mean on this PR. But now that you mention it. It could be a useful comment in the code... except that it will likely get out of sync with the code. On the other hand, its probably not something that changes that often. I think I've come full circle, I think a code comment would be good, despite the risk that it gets out of sync with the code, it would make it much faster for someone reading this code to understand what the output would look like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it possible to measure response time in logs. We almost always want things to respond faster than one second, so second granularity is useless for this purpose.
I used the technique suggested in this Stackoverflow answer.