Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable liblouis multi pass (disable pass1only flag) with a hidden config parameter #7702

Merged
merged 1 commit into from Nov 23, 2017

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Oct 26, 2017

Link to issue number:

Provides test possibilities for #7301
Provides a workaround for #7693

Summary of the issue:

We currently use pass1only for liblouis translation, as not providing this flag and thus using multi pass theoretically breaks input to output position mapping.

Description of how this pull request fixes the issue:

Adds outputPass1Only to the braille section of the configuration. This is not visible in the GUI. You can change this by running this from a python console

import config; config.conf["braille"]["outputPass1Only"]=False

Change it back with

import config; config.conf["braille"]["outputPass1Only"]=True

Testing performed:

I will provide a try build for this later today.

Known issues with pull request:

None, except it is a bit difficult to change this for non-power users.

Changes entry

…y in the braille category. This is not GUI configurable
@michaelDCurran
Copy link
Member

I think there is a typo in the python console command. One of them should be true?

@michaelDCurran
Copy link
Member

I pushed a try build. If this succeeds, I'll incubate.

@LeonarddeR
Copy link
Collaborator Author

@michaelDCurran commented on 26 okt. 2017 07:03 CEST:

I think there is a typo in the python console command. One of them should be true?

Yuck, fixed that.

@LeonarddeR
Copy link
Collaborator Author

@michaelDCurran: Is this still in your view for 2017.4? Note that this can be even merged with a new what's new entry for developers, as these are not part of the translations.

@michaelDCurran
Copy link
Member

Sorry, I should have merged this much earlier. I'm not going to include this in 2017.4, but it is already available in Next snapshots, and I can get it into master as soon as we branch for rc (today). So there are plenty of ways people can test this out.

@michaelDCurran michaelDCurran merged commit 15aba2a into nvaccess:master Nov 23, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants