Enable liblouis multi pass (disable pass1only flag) with a hidden config parameter #7702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Provides test possibilities for #7301
Provides a workaround for #7693
Summary of the issue:
We currently use pass1only for liblouis translation, as not providing this flag and thus using multi pass theoretically breaks input to output position mapping.
Description of how this pull request fixes the issue:
Adds outputPass1Only to the braille section of the configuration. This is not visible in the GUI. You can change this by running this from a python console
Change it back with
Testing performed:
I will provide a try build for this later today.
Known issues with pull request:
None, except it is a bit difficult to change this for non-power users.
Changes entry