diff --git a/src/import/chips/p9/procedures/hwp/nest/p9_sbe_fabricinit.C b/src/import/chips/p9/procedures/hwp/nest/p9_sbe_fabricinit.C index 3cd54b7f5..3235616f6 100755 --- a/src/import/chips/p9/procedures/hwp/nest/p9_sbe_fabricinit.C +++ b/src/import/chips/p9/procedures/hwp/nest/p9_sbe_fabricinit.C @@ -27,14 +27,13 @@ /// @brief Initialize island-mode fabric configuration (FAPI2) /// /// @author Joe McGill -/// @author Christy Graves /// // // *HWP HWP Owner: Joe McGill // *HWP FW Owner: Thi Tran // *HWP Team: Nest -// *HWP Level: 2 +// *HWP Level: 3 // *HWP Consumed by: SBE // @@ -54,12 +53,12 @@ const uint64_t FABRICINIT_DELAY_HW_NS = 1000; // 1us const uint64_t FABRICINIT_DELAY_SIM_CYCLES = 200; -// ADU Command Register field/bit definitions +// ADU Command Register field definitions const uint32_t ALTD_CMD_TTYPE_PBOP_EN_ALL = 0x3F; const uint32_t ALTD_CMD_TSIZE_PBOP_EN_ALL = 0x0B; const uint32_t ALTD_CMD_SCOPE_GROUP = 0x3; -// ADU Status Register field/bit definitions +// ADU Status Register field definitions const uint32_t ALTD_STATUS_CRESP_ACK_DONE = 0x04; @@ -109,8 +108,8 @@ p9_sbe_fabricinit(const fapi2::Target& i_target) PU_PB_CENT_SM0_PB_CENT_HP_MODE_CURR_CFG_XLATE_ADDR_TO_ID_LEN>(l_fbc_xlate_addr_to_id); l_hp_mode_data.clearBit() // PHYP is group - .clearBit() // large system map - .clearBit(); // disable Dcache CAPP mode + .clearBit() // large system map + .clearBit(); // disable Dcache CAPP mode if (l_pump_mode == fapi2::ENUM_ATTR_PROC_FABRIC_PUMP_MODE_CHIP_IS_NODE) // pump mode { @@ -144,8 +143,7 @@ p9_sbe_fabricinit(const fapi2::Target& i_target) "Error from p9_fbc_utils_get_fbc_state"); FAPI_ASSERT(l_fbc_is_running, fapi2::P9_SBE_FABRICINIT_FBC_STOPPED_ERR(). - set_TARGET(i_target). - set_FBC_RUNNING(l_fbc_is_running), + set_TARGET(i_target), "Pervasive stop control is asserted, so fabricinit will not run!"); // write ADU Command Register to attempt lock acquisition @@ -189,8 +187,8 @@ p9_sbe_fabricinit(const fapi2::Target& i_target) (ALTD_STATUS_CRESP_ACK_DONE); FAPI_ASSERT(l_status_data_exp == l_status_data_act, - fapi2::P9_SBE_FABRICINIT_FAILED_ERR().set_TARGET(i_target). - set_ADU_STATUS_EXP(l_status_data_act). + fapi2::P9_SBE_FABRICINIT_FAILED_ERR(). + set_TARGET(i_target). set_ADU_STATUS_ACT(l_status_data_act), "Fabric init failed, or mismatch in expected ADU status!"); @@ -206,9 +204,7 @@ p9_sbe_fabricinit(const fapi2::Target& i_target) "Error from p9_fbc_utils_get_fbc_state"); FAPI_ASSERT(l_fbc_is_initialized && l_fbc_is_running, fapi2::P9_SBE_FABRICINIT_NO_INIT_ERR(). - set_TARGET(i_target). - set_FBC_INITIALIZED(l_fbc_is_initialized). - set_FBC_RUNNING(l_fbc_is_running), + set_TARGET(i_target), "ADU command succeded, but fabric was not cleanly initialized!"); fapi_try_exit: diff --git a/src/import/chips/p9/procedures/hwp/nest/p9_sbe_fabricinit.H b/src/import/chips/p9/procedures/hwp/nest/p9_sbe_fabricinit.H index f0b2ecd7b..532b3da4e 100755 --- a/src/import/chips/p9/procedures/hwp/nest/p9_sbe_fabricinit.H +++ b/src/import/chips/p9/procedures/hwp/nest/p9_sbe_fabricinit.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER sbe Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2015,2016 */ +/* Contributors Listed Below - COPYRIGHT 2015,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -60,14 +60,13 @@ /// - Confirm state of fabric init control /// /// @author Joe McGill -/// @author Christy Graves /// // // *HWP HWP Owner: Joe McGill // *HWP FW Owner: Thi Tran // *HWP Team: Nest -// *HWP Level: 2 +// *HWP Level: 3 // *HWP Consumed by: SBE // diff --git a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_fabricinit_errors.xml b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_fabricinit_errors.xml index cd68f2f43..1f21da000 100755 --- a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_fabricinit_errors.xml +++ b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_fabricinit_errors.xml @@ -5,7 +5,7 @@ - + @@ -22,8 +22,17 @@ - + + + REG_FFDC_SBE_FABRICINIT + PU_PB_CENT_SM0_PB_CENT_MODE + PU_PB_CENT_SM0_PB_CENT_HP_MODE_NEXT + PU_PB_CENT_SM0_PB_CENT_HP_MODE_CURR + PU_PB_CENT_SM0_PB_CENT_HPX_MODE_NEXT + PU_PB_CENT_SM0_PB_CENT_HPX_MODE_CURR + PU_SND_MODE_REG + @@ -33,7 +42,21 @@ Fabric init sequence not attempted, fabric arbitration is stopped. TARGET - FBC_RUNNING + + REG_FFDC_SBE_FABRICINIT + TARGET_TYPE_PROC_CHIP + TARGET + + + TARGET + HIGH + + + TARGET + + + TARGET + @@ -44,8 +67,22 @@ Fabric init failed, or mismatch in expected ADU status. TARGET - ADU_STATUS_EXP ADU_STATUS_ACT + + REG_FFDC_SBE_FABRICINIT + TARGET_TYPE_PROC_CHIP + TARGET + + + TARGET + HIGH + + + TARGET + + + TARGET + @@ -56,8 +93,21 @@ ADU operation completed successfully, but fabric was not initialized. TARGET - FBC_INITIALIZED - FBC_RUNNING + + REG_FFDC_SBE_FABRICINIT + TARGET_TYPE_PROC_CHIP + TARGET + + + TARGET + HIGH + + + TARGET + + + TARGET +