From c3a568c1e8c1ab990bc3e3824567362099d9f119 Mon Sep 17 00:00:00 2001 From: Vasant Hegde Date: Sun, 2 Apr 2017 16:37:29 +0530 Subject: [PATCH] hdat: Use dt_add_property_nstr instead of duplicating code Signed-off-by: Vasant Hegde Signed-off-by: Stewart Smith --- hdata/vpd.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hdata/vpd.c b/hdata/vpd.c index 5a6614096589..7f3954a081ee 100644 --- a/hdata/vpd.c +++ b/hdata/vpd.c @@ -562,18 +562,12 @@ static void sysvpd_parse_legacy(const void *sysvpd, unsigned int sysvpd_sz) const char *model; const char *system_id; const char *brand; - char *str; uint8_t sz; model = vpd_find(sysvpd, sysvpd_sz, "VSYS", "TM", &sz); - if (model) { - str = zalloc(sz + 1); - if (str) { - memcpy(str, model, sz); - dt_add_property_string(dt_root, "model", str); - free(str); - } - } else + if (model) + dt_add_property_nstr(dt_root, "model", model, sz); + else dt_add_property_string(dt_root, "model", "Unknown"); system_id = vpd_find(sysvpd, sysvpd_sz, "VSYS", "SE", &sz);