[pdatagen] Generate Metric type accessors #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4811 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 180 180
Lines 10590 10590
=======================================
Hits 9612 9612
Misses 761 761
Partials 217 217
Continue to review full report at Codecov.
|
dmitryax
requested review from
bogdandrutu
and removed request for
tigrannajaryan
bogdandrutu
reviewed
Feb 8, 2022
| @@ -1106,6 +1124,18 @@ func (ms NumberDataPoint) SetTimestamp(v Timestamp) { | |||
| (*ms.orig).TimeUnixNano = uint64(v) | |||
| } | |||
|
|
|||
| // Type returns the type of the value for this NumberDataPoint. | |||
| // Calling this function on zero-initialized NumberDataPoint will cause a panic. | |||
| func (ms NumberDataPoint) Type() MetricValueType { | |||
There was a problem hiding this comment.
On the list of "may fix": MetricValueType does not sound as the best name for the enum. Maybe NumberValueType?
PointValueType? Not sure, just open an issue, this name does not sound very clear to me, because I would ask why Histogram is not a value type.
There was a problem hiding this comment.
Makes sense. Filed an issue #4819
bogdandrutu
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4782