Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6166 phase2 #25

Merged
merged 47 commits into from Dec 1, 2011
Merged

6166 phase2 #25

merged 47 commits into from Dec 1, 2011

Conversation

will-moore
Copy link
Member

This branch extends the Web ROI work done in ola's feature/big_image_roi branch (PR-16), based on feedback from Paul.

Will Moore and others added 30 commits September 21, 2011 13:34
ROI rows still show 'ROI' thumbnail as before, but now each row also shows
a Shape thumbnail.
Also removed 'Shape' text from icon column header and
added the Point in the ROI & Shape thumbnails.
Will Moore added 14 commits November 3, 2011 16:35
If width OR height exceed omero.pixeldata.max_plane_width etc then we
return a blank thumbnail with 'ROI too large' text
Use tool-tip to display the full text.
Use border around table cells instead of padding since Safari was not hiding
padding on each tbody collapse, but adding padding for expand
This makes the web consistent with Insight. There is no 'text colour' attribute
for shapes, so you have to use the line colour.
Also fixed bug where selecting the shape increases the opacity of the
fill.
Use the stroke colour to fill Text shapes, use stroke of Text shape to highlight.
left over from the text & stroke/fill work in previous commits.
@chris-allan
Copy link
Member

@will-moore: A couple bugs:

  1. When clicking on the "root" table header, the first ROI is hidden
  2. There is a wrapping issue with contiguous text:

aaaa wrapping issue

Will Moore added 2 commits November 25, 2011 13:32
By breaking up long words to wrap in Image viewer and using css in table
@chris-allan
Copy link
Member

@will-moore: All looking good in Firefox (8.0.1; Mac OS X):

Wrapping issue Firefox fix

...but in IE8 we've got a real mess:

IE8 text issues

In order for c8190d3 to work consistently across all browsers the word-wrap: break-word CSS must be on a block element such as <p>, it is insufficient for it to be located on the <td>.

@chris-allan
Copy link
Member

@will-moore, @aleksandra-tarkowska: Looks good enough to me. Once we get MSIE 8 sorted out with respect to the viewer we can revisit any issues with the ROI table. Merging.

chris-allan added a commit that referenced this pull request Dec 1, 2011
@chris-allan chris-allan merged commit 16fcfd6 into ome:develop Dec 1, 2011
joshmoore added a commit to snoopycrimecop/openmicroscopy that referenced this pull request May 2, 2014
Blitz re.saveDefaults() saveAs if rdef not owned. See PR2365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants