New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6166 phase2 #25
6166 phase2 #25
Conversation
…o that position, close #6578
ROI rows still show 'ROI' thumbnail as before, but now each row also shows a Shape thumbnail. Also removed 'Shape' text from icon column header and added the Point in the ROI & Shape thumbnails.
If width OR height exceed omero.pixeldata.max_plane_width etc then we return a blank thumbnail with 'ROI too large' text
Use tool-tip to display the full text.
Use border around table cells instead of padding since Safari was not hiding padding on each tbody collapse, but adding padding for expand
This makes the web consistent with Insight. There is no 'text colour' attribute for shapes, so you have to use the line colour.
Also fixed bug where selecting the shape increases the opacity of the fill.
Use the stroke colour to fill Text shapes, use stroke of Text shape to highlight.
left over from the text & stroke/fill work in previous commits.
@will-moore: A couple bugs:
|
By breaking up long words to wrap in Image viewer and using css in table
@will-moore: All looking good in Firefox (8.0.1; Mac OS X): ...but in IE8 we've got a real mess: In order for c8190d3 to work consistently across all browsers the |
@will-moore, @aleksandra-tarkowska: Looks good enough to me. Once we get MSIE 8 sorted out with respect to the viewer we can revisit any issues with the ROI table. Merging. |
Blitz re.saveDefaults() saveAs if rdef not owned. See PR2365
This branch extends the Web ROI work done in ola's feature/big_image_roi branch (PR-16), based on feedback from Paul.