Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contributing process #148

Merged
merged 3 commits into from Apr 4, 2014
Merged

Improve contributing process #148

merged 3 commits into from Apr 4, 2014

Conversation

Floppy
Copy link
Member

@Floppy Floppy commented Apr 2, 2014

Dropped prose.io, and updated instructions. Makes logging in a lot easier for new users

Makes logging in a lot easier for new users
@PaulJRobinson
Copy link
Contributor

How can I check out the new system if this hasn't merged yet? Whilst I can imagine the Github editting system to be extremely functional and rugged (and not lose those edits you mentioned) I'm not convinced it will be a more appealing option to the non-techie.

@Floppy
Copy link
Member Author

Floppy commented Apr 3, 2014

A good point. Try this, it'll be the same:

@Floppy
Copy link
Member Author

Floppy commented Apr 3, 2014

The github UI is more complex, but prose.io's login handling is so fraught with error that I think this is an improvement.

@Floppy
Copy link
Member Author

Floppy commented Apr 3, 2014

Actually it looks like prose's auth handling is currently broken, so hopefully this will get a fix and we can go back to using it. See prose/prose#643

@Floppy
Copy link
Member Author

Floppy commented Apr 3, 2014

Interestingly, we're not the first to switch back for exactly this reason: Project-Interoperability/project-interoperability.github.io@017be3a

Will see if I can find time to try to fix this in prose, unless they come up with a fix fairly soon.

@Floppy
Copy link
Member Author

Floppy commented Apr 3, 2014

I think this PR would be good to merge as the prose flow is currently broken, but I will change it back as soon as it's fixed, that's a promise, as I agree the UI is better for new users.

@PaulJRobinson
Copy link
Contributor

👍

@philipjohn
Copy link
Member

👍 with one suggested tweak to the text:

  • "Some existing contributors will have to agree to the change before it's merged into the master version"
  • "There will then be a vote, and possibly debate, amongst contributors on whether to adopt the change"

Just because the former could be interpreted as sounding like it goes through some sort of self-appointed approval committee rather than a democratic vote.

@Floppy
Copy link
Member Author

Floppy commented Apr 3, 2014

Good change, have integrated it.

@frankieroberto
Copy link
Contributor

👍

Floppy added a commit that referenced this pull request Apr 4, 2014
@Floppy Floppy merged commit f86db6f into gh-pages Apr 4, 2014
@Floppy Floppy deleted the better-contrib branch April 4, 2014 22:07
@Floppy
Copy link
Member Author

Floppy commented Feb 8, 2017

This proposal is open for discussion and voting. If you are a contributor to this repository (and not the proposer), you may vote on whether or not it is accepted.

How to vote

Vote by entering one of the following symbols in a comment on this pull request. Only your last vote will be counted, and you may change your vote at any time until the change is accepted or closed.

vote symbol type this points
Agree 👍 :thumbsup: 1
Abstain :hand: -1
Block 👎 :thumbsdown: -1000

Proposals will be accepted and merged once they have a total of 2 points when all votes are counted. Votes will be open for a minimum of 7 days, but will be closed if the proposal is not accepted after 90.

Votes are counted automatically here, and results are set in the merge status checks below.

Changes

If the proposer makes a change to the proposal, no votes cast before that change will be counted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants