New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve contributing process #148
Conversation
Makes logging in a lot easier for new users
How can I check out the new system if this hasn't merged yet? Whilst I can imagine the Github editting system to be extremely functional and rugged (and not lose those edits you mentioned) I'm not convinced it will be a more appealing option to the non-techie. |
A good point. Try this, it'll be the same:
|
The github UI is more complex, but prose.io's login handling is so fraught with error that I think this is an improvement. |
Actually it looks like prose's auth handling is currently broken, so hopefully this will get a fix and we can go back to using it. See prose/prose#643 |
Interestingly, we're not the first to switch back for exactly this reason: Project-Interoperability/project-interoperability.github.io@017be3a Will see if I can find time to try to fix this in prose, unless they come up with a fix fairly soon. |
I think this PR would be good to merge as the prose flow is currently broken, but I will change it back as soon as it's fixed, that's a promise, as I agree the UI is better for new users. |
👍 |
👍 with one suggested tweak to the text:
Just because the former could be interpreted as sounding like it goes through some sort of self-appointed approval committee rather than a democratic vote. |
Good change, have integrated it. |
👍 |
Conflicts: contributing.md
This proposal is open for discussion and voting. If you are a contributor to this repository (and not the proposer), you may vote on whether or not it is accepted. How to voteVote by entering one of the following symbols in a comment on this pull request. Only your last vote will be counted, and you may change your vote at any time until the change is accepted or closed.
Proposals will be accepted and merged once they have a total of 2 points when all votes are counted. Votes will be open for a minimum of 7 days, but will be closed if the proposal is not accepted after 90. Votes are counted automatically here, and results are set in the merge status checks below. ChangesIf the proposer makes a change to the proposal, no votes cast before that change will be counted. |
Dropped prose.io, and updated instructions. Makes logging in a lot easier for new users