Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
remove improper assert usage
There're many talks about it. An assert should be used for `never happen` cases, not common paramaters validating. With grep, we could many all assert statement used in none-test codes: cinder/volume/drivers/san/solaris.py:110: cinder/volume/drivers/san/solaris.py:116: cinder/volume/drivers/san/solaris.py:161: cinder/volume/drivers/san/solaris.py:162: cinder/volume/drivers/san/solaris.py:163: cinder/volume/drivers/san/solaris.py:164: cinder/volume/drivers/san/solaris.py:170: checking cmd output which should never changed, so leave it cinder/db/sqlalchemy/migration.py:113: ensure file existence from impossible cases, so leave it cinder/utils.py: used for functional flow, so use ValueError instead fixes bug #1199354 Change-Id: I2b1701269bdf7c8737548e57bd940921a6256372
- Loading branch information