Navigation Menu

Skip to content

Commit

Permalink
Remove 'location' from GlanceImageService
Browse files Browse the repository at this point in the history
Glance no longer returns location through its public API, so we
should not attempt to display it. Addresses bug 911599.

Change-Id: I3400006eb6ab94095c0c2d2b5dc90cb9b7775a84
  • Loading branch information
bcwaldon committed Jan 11, 2012
1 parent 0bbf67c commit 3e015b8
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
1 change: 1 addition & 0 deletions .mailmap
Expand Up @@ -9,6 +9,7 @@
<ant@openstack.org> <amesserl@rackspace.com>
<Armando.Migliaccio@eu.citrix.com> <armando.migliaccio@citrix.com>
<brian.lamar@rackspace.com> <brian.lamar@gmail.com>
<brian.waldon@rackspace.com> <bcwaldon@gmail.com>
<bschott@isi.edu> <bfschott@gmail.com>
<cbehrens@codestud.com> <chris.behrens@rackspace.com>
<chiradeep@cloud.com> <chiradeep@chiradeep-lt2>
Expand Down
2 changes: 1 addition & 1 deletion nova/image/glance.py
Expand Up @@ -435,7 +435,7 @@ def _convert_to_string(metadata):


def _limit_attributes(image_meta):
IMAGE_ATTRIBUTES = ['size', 'location', 'disk_format',
IMAGE_ATTRIBUTES = ['size', 'disk_format',
'container_format', 'checksum', 'id',
'name', 'created_at', 'updated_at',
'deleted_at', 'deleted', 'status',
Expand Down
6 changes: 0 additions & 6 deletions nova/tests/image/test_glance.py
Expand Up @@ -129,7 +129,6 @@ def test_create_with_instance_id(self):
'size': None,
'min_disk': None,
'min_ram': None,
'location': None,
'disk_format': None,
'container_format': None,
'checksum': None,
Expand Down Expand Up @@ -161,7 +160,6 @@ def test_create_without_instance_id(self):
'size': None,
'min_disk': None,
'min_ram': None,
'location': None,
'disk_format': None,
'container_format': None,
'checksum': None,
Expand Down Expand Up @@ -311,7 +309,6 @@ def test_detail_marker(self):
'size': None,
'min_disk': None,
'min_ram': None,
'location': None,
'disk_format': None,
'container_format': None,
'checksum': None,
Expand Down Expand Up @@ -356,7 +353,6 @@ def test_detail_marker_and_limit(self):
'size': None,
'min_disk': None,
'min_ram': None,
'location': None,
'disk_format': None,
'container_format': None,
'checksum': None,
Expand Down Expand Up @@ -436,7 +432,6 @@ def test_show_passes_through_to_client(self):
'size': None,
'min_disk': None,
'min_ram': None,
'location': None,
'disk_format': None,
'container_format': None,
'checksum': None,
Expand Down Expand Up @@ -472,7 +467,6 @@ def test_detail_passes_through_to_client(self):
'size': None,
'min_disk': None,
'min_ram': None,
'location': None,
'disk_format': None,
'container_format': None,
'checksum': None,
Expand Down

0 comments on commit 3e015b8

Please sign in to comment.