Navigation Menu

Skip to content

Commit

Permalink
nova-rootwrap: wait() for return code before exit
Browse files Browse the repository at this point in the history
nova-rootwrap does not wait() for the subprocess it executes to complete before
returning its return code. This often ends up in 0 being returned regardless of
failure/success and causing unforeseen problems in Nova.

Fixes bug #928566

Change-Id: I9b6d85c747513086d0e774cb92ba403886b3283c
  • Loading branch information
Adam Gandelman committed Feb 8, 2012
1 parent b0a708f commit 40206cb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions bin/nova-rootwrap
Expand Up @@ -67,6 +67,7 @@ if __name__ == '__main__':
stdout=sys.stdout,
stderr=sys.stderr,
env=filtermatch.get_environment(userargs))
obj.wait()
sys.exit(obj.returncode)

print "Unauthorized command: %s" % ' '.join(userargs)
Expand Down

0 comments on commit 40206cb

Please sign in to comment.