Skip to content

Commit

Permalink
Use XMLDictSerializer for resource extensions.
Browse files Browse the repository at this point in the history
Patches around bug 852141 by using the XMLDictSerializer instead of
the ExtensionsXMLSerializer for XML serialization of resource
extensions.  This will allow XML to be emitted, but does not correct
the underlying problem: many existing resource extensions do not
have defined XML serializers.  (Additionally, existing serializers,
including ExtensionsXMLSerializer, should be converted to
templates.)

Change-Id: If0fb0603920d04834368ed654f2a71d3e5300f7f
  • Loading branch information
Kevin L. Mitchell committed Nov 22, 2011
1 parent e35ed7c commit b74dee5
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions nova/api/openstack/v2/extensions.py
Expand Up @@ -276,7 +276,7 @@ def __init__(self, application, ext_mgr=None):
mapper = nova.api.openstack.v2.ProjectMapper()

serializer = wsgi.ResponseSerializer(
{'application/xml': ExtensionsXMLSerializer()})
{'application/xml': wsgi.XMLDictSerializer()})
# extended resources
for resource in ext_mgr.get_resources():
LOG.debug(_('Extended resource: %s'),
Expand Down Expand Up @@ -371,8 +371,11 @@ def register(self, ext):
def get_resources(self):
"""Returns a list of ResourceExtension objects."""
resources = []
serializer = wsgi.ResponseSerializer(
{'application/xml': ExtensionsXMLSerializer()})
resources.append(ResourceExtension('extensions',
ExtensionsResource(self)))
ExtensionsResource(self),
serializer=serializer))
for ext in self.extensions.values():
try:
resources.extend(ext.get_resources())
Expand Down

0 comments on commit b74dee5

Please sign in to comment.