New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client trying to sync deleted File #2919
Comments
@Turbocube644 Is there anything about the filename or the directory it is stored in that could help us to track this down? Special characters? |
The file name only consists out of ASCII letters, so no special characters. |
@icewind1991 @PVince81 A server file scanner issue? |
Can you check the database: |
I checked the database: the query returns zero entries. |
@guruz seems not. If the file is neither on disk nor in the oc_filecache, the server should not know anything about it and return 404. How would the client behave ? What if it's trying to resume a failed download on a file that was deleted ? (just wild guess) |
Should not happen here, if the file was not discovered the download will not be attempted to resume. @Turbocube644 Are you 100% about that DB query results? Also about if the file maybe exists on your server hd? |
Yes, I'm 100% sure about the DB query results. I checked them twice. |
Do you find an entry about the file in the apache access_log? That entry would be interesting. |
Unfortunately I don't have access to the logs... |
@Turbocube644 ok, please create a client log file that shows a sync run where your client tries to download the files. |
the files is pretty big... |
@Turbocube644 Thanks for the log! That's interesting. The whole sync failed because of a timeout when trying to delete workspace/.metadata/.plugins/org.eclipse.core.resources/.history/6b/b0c2edc09db40014111b916fb9f5489a from the server. That file is found on the server - is that correct? The confusing messages saying 'Error downloading ...' are actually about DELETE requests to the server failing. But then there's also a file ending in c06771af7ab50014115594bbc2625284 that shows up only in the remote reconciliation logs (why is it assumed to be on the server?). Marking this as REMOVE and trying to delete it is bound to cause trouble. |
The etag for the directory that contains c06771af7ab50014115594bbc2625284 didn't change, which is why the remote discovery assumes the file is still present and attempts to delete it. |
We're considering whether to make 404 on DELETE a non-fatal error that deletes the file from the DB. But it won't be in 1.8.0. |
With the patch applied I no longer get stuck files in this situation. |
Hold on.. something for @PVince81 ? |
@dragotin OK to cherry-pick the above commit into 1.8 for rc2? It's a gold ticket |
Is it a file inside a shared folder ? Is the user seeing the bug a recipient or owner ? Is the shared folder inside a subfolder ? If yes, it could be the cross-storage etag propagation issue. |
Yes, please pick the patch now. |
Merged into the 1.8 branch now. |
@Turbocube644 The patch was merged, could you test it with tomorrow's build at http://download.owncloud.com/desktop/daily/ ? |
@Turbocube644 Could you still reply to the questions in #2919 (comment) ? |
No, it wasn't inside a Shared folder. |
Okay! Closing since the patch fixed it when I reproduced the problem. |
Just to give an update: |
The Client (1.8.0 beta1) tries to sync a file, which has been deleted. It shows the following error: "Error downloading [filename] - Server replied: Not found". The file neither exists on the server nor the local computer. This happens for multiple files, that have been deleted.
For some classes, I often get a Timeout.
The server ist still 7.0.4 (because the update routine thinks it is the newest version)
The text was updated successfully, but these errors were encountered: