Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reconcilation to sync thread and slim down C/C++ mishmash #3064

Closed
guruz opened this issue Apr 2, 2015 · 4 comments
Closed

Move reconcilation to sync thread and slim down C/C++ mishmash #3064

guruz opened this issue Apr 2, 2015 · 4 comments

Comments

@guruz
Copy link
Contributor

guruz commented Apr 2, 2015

void SyncEngine::slotDiscoveryJobFinished(int discoveryResult)

...since it can potentially take a quite long time (proportional to amount of files/folders) and then block the UI.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@guruz guruz self-assigned this Apr 2, 2015
@guruz guruz added this to the 1.9 - Multi-account milestone Apr 2, 2015
@guruz guruz assigned jturcotte and unassigned guruz Apr 17, 2015
@guruz guruz changed the title Investigate if reconciliation should be done in the sync thread Move reconcilation to sync thread Apr 17, 2015
@guruz
Copy link
Contributor Author

guruz commented Apr 17, 2015

Also: Port csync_reconcile to C++ so we can remove the two csync_walk_local_tree calls and have csync_reconcile directly create SyncFileItem.

@guruz guruz changed the title Move reconcilation to sync thread Move reconcilation to sync thread and slim down C/C++ mishmash Apr 17, 2015
@jturcotte jturcotte modified the milestones: backlog, 2.0 - Multi-account Jun 3, 2015
@guruz guruz modified the milestones: 2.2-next, backlog Sep 28, 2015
@jturcotte jturcotte removed this from the 2.2-next milestone Jan 14, 2016
@guruz
Copy link
Contributor Author

guruz commented Jan 13, 2017

I had quickly added Peak Memory tag here but that is wrong, the memory is already freed by then.
The peak should be after // The map was used for merging trees, convert it to a list:

@guruz
Copy link
Contributor Author

guruz commented Sep 21, 2017

This is partly done in 2.4.
Should still be moved to sync thread..

@ogoffart
Copy link
Contributor

there is no more reconcile phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants