Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert datamapper's explicit id castings on strings once dm-core issue is fixed #1186

Closed
dariocravero opened this issue Mar 26, 2013 · 5 comments
Assignees
Labels
Milestone

Comments

@dariocravero
Copy link

@padrino/core-members once this datamapper issue with ruby 2.0 is released (it's already fixed on edge) datamapper/dm-core/issues/242, we should remove the admin's explicit castings of strings L103. We can also remove https://github.com/padrino/padrino-framework/blob/master/padrino-admin/lib/padrino-admin/generators/orm.rb#L152-L158 and bake it on the controller again.

@ujifgc
Copy link
Member

ujifgc commented Jun 17, 2013

I can confirm that 'dm-core', '1.2.1' from rubygems can now #get strings.

@nesquena
Copy link
Member

Yeah seems that the extra casting can thankfully be removed soon.

@ghost ghost assigned dariocravero Jul 1, 2013
@DAddYE
Copy link
Member

DAddYE commented Jul 1, 2013

@dariocravero can u handle this?

@dariocravero
Copy link
Author

Yup, will do that in a bit.

On Monday, July 1, 2013, DAddYE wrote:

@dariocravero https://github.com/dariocravero can u handle this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1186#issuecomment-20269908
.

Darío

@DAddYE
Copy link
Member

DAddYE commented Jul 2, 2013

Bump!

deni64k pushed a commit to deni64k/padrino-framework that referenced this issue Jul 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants