Padrino::Server - call expand_path on PID file option #1232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally Rack::Server would expand the PID (-P) argument. But with
Padrino::Server
, there is noARGV
forRack::Server
to parse, so a PID option that's not absolute will causePadrino::Server
to silently fail when it daemonizes as it will be attempting to open the file from the root directory ("/") not the directory from which it was invoked.On a related note, why not just mimic the
Rack::Server
/rackup
options? While it's is a minor issue, standardization is good. For example, this is somewhat confusing: