Helpers documentation cleanup #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
September 15, 2013 08:20
|
Travis seems to have problems with with ruby 2.0 => what does |
|
Thanks! |
|
Thanks @namusyaka, you've opend my eyes. And the tests are now green, so ready for a merge. |
|
Yeah, looks good to me. |
namusyaka
added a commit
that referenced
this pull request
Sep 15, 2013
…entation-cleanup Helpers documentation cleanup
|
It's always a pleasure to clean up the code base and make it more beautiful. And thanks for let me learning the whole collaboration thing and the nice tips you and @ujifgc gave me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time I run through all tests after making a
git pull --rebase padrino masterand they all passed.