Performance tests #1419
Merged
Performance tests #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # TODO Get Slim concat working | ||
| # assert_have_selector 'p', :content => "Concat Line 3", :count => 1 | ||
| #TODO Get Slim concat working | ||
| assert_have_selector 'p', :content => "Concat Line 3", :count => 1 |
There was a problem hiding this comment.
Travis failed this test.
There was a problem hiding this comment.
Someway this stash slipped into my commits, sorry for that. I forgot to run rake test on my machine before creating this pull request.
|
Great! Thanks, @matthias-guenther ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After understanding the performance component of Padrino I spend the evening to write tests for the
os.rbfile inside the project. First of all I need a code review to be sure that I can go in with the testing because this is the first time I'm working with minitest.Best regards
Matthias