Fix and cleanup output handlers

[ujifgc]

Warning: this disables concatenating of - in Slim and Haml templates #1441 (comment).

[namusyaka]

@ujifgc Thank you!

+1

BTW, do we have to rewrite padrino-admin templates of slim?
I think we should replace - with =. e.g. - form_tag ..

[ujifgc]

Yes, padrino-admin pages are broken at this PR.

[namusyaka]

I fixed the broken templates.
Please use it if you like.

[nesquena]

Nice job @ujifgc and @namusyaka! really glad to see this cleanup. template handling, especially with capture has been half-broken for a long time now. Good to see this getting solidified for 0.12

[DAddYE]

Indeed awesome work guys. Keep going.

[ujifgc]

The last commit 80a0e24 disables concatenating of - in Slim and Haml templates.

If we decide we could implement a flag to enable legacy behavior of Padrino template handlers and concatenate on - (though I would not).

If some legacy app wants to keep wrong behavior, the monkey patch would be:

For HamlHandler:

class Padrino::Helpers::OutputHelpers::HamlHandler
  def concat_to_template(text="")
    template.haml_concat(text)
    nil
  end 
end

For SlimHandler:

class Padrino::Helpers::OutputHelpers::SlimHandler
  def concat_to_template(text="")
    self.output_buffer << text
    nil
  end
end

Please, check your apps with this PR and comment. I think, it's ready.

[nesquena]

If I understand correctly it means almost every padrino app using forms will need to tweak every - to = or their forms will be totally broken. Seems like 0.12.0 is as good a time as any to make this fairly major breaking change. What do you all think @padrino/core-members ?

[ujifgc]

Yep. A tweak of template block helpers from - to = or the monkey patch I provided. The monkey patch actually doesn't break anything except the test for concatenating -.

[nesquena]

Yeah, we should document the monkeypatch in the blog post for 0.12.0 release (#1019)

[dariocravero]

I think the breaking change makes a lot of sense towards readability and predictability of the code going further. Excellent job guys! :) Thanks so much!!