Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move support_lite and locale to padrino-support gem, restructure it #1612

Merged
merged 4 commits into from Mar 6, 2014

Conversation

ujifgc
Copy link
Member

@ujifgc ujifgc commented Mar 2, 2014

ref #1611

This looses the entanglement a little.

@@ -0,0 +1,27 @@
#!/usr/bin/env gem build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be padrino-support.gemspec.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

@dariocravero
Copy link

Looks good to me! It's a much cleaner approach. @padrino/core-members?

@namusyaka
Copy link
Contributor

@ujifgc
Copy link
Member Author

ujifgc commented Mar 2, 2014

Done!

@namusyaka
Copy link
Contributor

Thank you for fast & great work!
Looks good to me!

@bhollis
Copy link

bhollis commented Mar 2, 2014

Oh, I just thought - I think padrino-core's .gemspec should have a dependency on padrino-support.

@ujifgc
Copy link
Member Author

ujifgc commented Mar 2, 2014

Done!

ujifgc added a commit that referenced this pull request Mar 6, 2014
move support_lite and locale to padrino-support gem, restructure it
@ujifgc ujifgc merged commit 6c992df into master Mar 6, 2014
@ujifgc ujifgc deleted the liberate-helpers branch March 6, 2014 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants