Get rid of the default_filters method #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
| @@ -89,7 +89,7 @@ | |||
| @app.reload! | |||
| get "/rand" | |||
| refute_equal last_body, body | |||
| assert_equal 2, @app.filters[:before].size # one is ours the other is default_filter for content type | |||
| assert_equal 1, @app.filters[:before].size # one is ours the other is default_filter for content type | |||
There was a problem hiding this comment.
we should update this comment and the one above on line 82?
There was a problem hiding this comment.
Good point, thanks!
Fixes wrong value of content-type when using css template helpers The :default_content_type should be respected for compatibility with Sinatra
|
👍 |
namusyaka
force-pushed
the
sinatra-compatibility
branch
from
76585bb
to
0b2b326
Compare
|
Thank you, everyone 👍 |
namusyaka
added a commit
that referenced
this pull request
Oct 1, 2014
Get rid of the default_filters method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
default_filtersmethod seems no need to us.Also the filter has continued to break the compatibility with Sinatra.
Thoughts?